LGTM
I second the bug filed against bot_update.
https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/git_recipes.py
File tools/push-to-trunk/git_recipes.py (right):
https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/git_recipes.py#newcode289
tools/push-to-trunk/git_recipes.py:289: raise
GitFailedException("Couldn't determin commit position for %s" %
nit: determine
https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/releases.py
File tools/push-to-trunk/releases.py (right):
https://codereview.chromium.org/716153002/diff/1/tools/push-to-trunk/releases.py#newcode233
tools/push-to-trunk/releases.py:233: return []
hm, is this actually being called?
If so, then is returning [] a good thing?
Otherwise, why not comment this function completely?
https://codereview.chromium.org/716153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
