On 2014/11/12 12:54:18, wingo wrote:
Andreas, I added state checks to the JS. I seem to recall some concern
that
throwing the exception directly from the next() or throw() functions
wouldn't
do
the right thing, but I don't see how that would be; perhaps I am
ignorant. If
this approach works for you I'll update the patch to remove the
corresponding
checks from the full-codegen generators.
Note that adding this runtime call reduces our performance by 33% on a
microbenchmark (from 30ms for a loop fetching 1e6 results from a
generator to
40ms). We can inline this if needed; dunno where and whether this
investment
is
worth it.
LGTM. (I don't recall that concern, do you remember in what context that
came
up?)
https://codereview.chromium.org/717123002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
