Revision: 25294
Author: [email protected]
Date: Wed Nov 12 13:12:17 2014 UTC
Log: Re-enable serialization under harmony-scoping.
[email protected]
BUG=v8:3689
LOG=N
Review URL: https://codereview.chromium.org/717153002
https://code.google.com/p/v8/source/detail?r=25294
Modified:
/branches/bleeding_edge/src/compiler.cc
/branches/bleeding_edge/test/mjsunit/regress/regress-2506.js
=======================================
--- /branches/bleeding_edge/src/compiler.cc Wed Nov 12 12:23:13 2014 UTC
+++ /branches/bleeding_edge/src/compiler.cc Wed Nov 12 13:12:17 2014 UTC
@@ -1243,9 +1243,7 @@
result = CompileToplevel(&info);
if (extension == NULL && !result.is_null() && !result->dont_cache()) {
compilation_cache->PutScript(source, context, result);
- // TODO(dslomov): Issue 3628.
- // Reenable when harmony scoping serialization issues are fixed.
- if (FLAG_serialize_toplevel && !FLAG_harmony_scoping &&
+ if (FLAG_serialize_toplevel &&
compile_options == ScriptCompiler::kProduceCodeCache) {
HistogramTimerScope histogram_timer(
isolate->counters()->compile_serialize());
=======================================
--- /branches/bleeding_edge/test/mjsunit/regress/regress-2506.js Thu Oct 23
12:30:20 2014 UTC
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-2506.js Wed Nov 12
13:12:17 2014 UTC
@@ -2,7 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
-// Flags: --harmony-scoping
+// TODO(dslomov): Bug 3689. Code caching does not work well with for-of
+// Flags: --harmony-scoping --cache=none
'use strict';
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
