lgtm
lgtm
https://codereview.chromium.org/716423002/diff/40001/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/716423002/diff/40001/src/scanner.cc#newcode83
src/scanner.cc:83: if (x > max_value) return -1;
I don't think this should block landing this, but I think it would be an
improvement if this error condition were handled in the parser, so that
an error could be reported (like "SyntaxError: Unicode escape sequences
cannot have a value exceeding U+10FFFF" or something).
So you'd want to make sure the value doesn't overflow, but max_value
checking could be verified in the parser. Again though, not a blocker, I
just think that would be easier on people. SpiderMonkey outputs some
pretty nice static errors for a lot of these, but V8 is just saying
"Unexpected token ____" which is not that great.
Not a blocker but something to think about
https://codereview.chromium.org/716423002/diff/40001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/716423002/diff/40001/test/cctest/test-parsing.cc#newcode4322
test/cctest/test-parsing.cc:4322: "var foob\\u{c481r = 0;",
Might be worth adding a test for `var \\not-u` being treated as a
syntax error.
https://codereview.chromium.org/716423002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
