Reviewers: Michael Starzinger,
https://codereview.chromium.org/726773002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/726773002/diff/1/src/objects.cc#newcode13100
src/objects.cc:13100: bool JSArray::HasReadOnlyLength(Handle<JSArray>
array) {
Should this just delegate to IsReadOnlyLengthDescriptor above? It's not
clear to me why the code in the two methods looks different...
https://codereview.chromium.org/726773002/diff/1/test/mjsunit/array-methods-read-only-length.js
File test/mjsunit/array-methods-read-only-length.js (right):
https://codereview.chromium.org/726773002/diff/1/test/mjsunit/array-methods-read-only-length.js#newcode154
test/mjsunit/array-methods-read-only-length.js:154: assertFalse(2 in b);
These have since been fixed.
Description:
Throw as per spec when modifying an Array with builtin methods
BUG=v8:3684
LOG=n
Please review this at https://codereview.chromium.org/726773002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+88, -129 lines):
M src/builtins.cc
M src/objects.h
M src/objects.cc
A + test/mjsunit/array-methods-read-only-length.js
D test/mjsunit/array-push-unshift-read-only-length.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
