Reviewers: jochen (slow),
Description:
Allow idle notification when incremental marking is turned off.
BUG=
Please review this at https://codereview.chromium.org/725583005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -3 lines):
M src/heap/heap.cc
Index: src/heap/heap.cc
diff --git a/src/heap/heap.cc b/src/heap/heap.cc
index
ed74e9698e36bc55644d7aac45e335617fea17fc..3c51b6e23f67e2af548057d590ac1f035b2dc039
100644
--- a/src/heap/heap.cc
+++ b/src/heap/heap.cc
@@ -4392,8 +4392,6 @@ bool Heap::WorthActivatingIncrementalMarking() {
bool Heap::IdleNotification(int idle_time_in_ms) {
- // If incremental marking is off, we do not perform idle notification.
- if (!FLAG_incremental_marking) return true;
base::ElapsedTimer timer;
timer.Start();
isolate()->counters()->gc_idle_time_allotted_in_ms()->AddSample(
@@ -4409,7 +4407,7 @@ bool Heap::IdleNotification(int idle_time_in_ms) {
heap_state.incremental_marking_stopped =
incremental_marking()->IsStopped();
// TODO(ulan): Start incremental marking only for large heaps.
heap_state.can_start_incremental_marking =
- incremental_marking()->ShouldActivate();
+ incremental_marking()->ShouldActivate() && FLAG_incremental_marking;
heap_state.sweeping_in_progress =
mark_compact_collector()->sweeping_in_progress();
heap_state.mark_compact_speed_in_bytes_per_ms =
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
