https://codereview.chromium.org/726773002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/726773002/diff/1/src/objects.cc#newcode13100
src/objects.cc:13100: bool JSArray::HasReadOnlyLength(Handle<JSArray>
array) {
On 2014/11/14 17:00:22, Michael Starzinger wrote:
On 2014/11/13 23:43:29, adamk wrote:
> Should this just delegate to IsReadOnlyLengthDescriptor above? It's
not clear
to
> me why the code in the two methods looks different...
Acknowledged. I chatted with Toon about this, semantically these two
methods
should do the same. But since the LookupIterator is the "better
implementation",
we should keep this method and instead deprecate the other one. So I
would just
keep it as it is for now (i.e. keep both methods) and maybe even add a
TODO to
IsReadOnlyLengthDescriptor that it is deprecated.
Thanks for the background, added a TODO.
https://codereview.chromium.org/726773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
