On 2014/11/18 11:52:24, aandrey wrote:
https://codereview.chromium.org/739523002/diff/1/src/debug.h
File src/debug.h (right):

https://codereview.chromium.org/739523002/diff/1/src/debug.h#newcode413
src/debug.h:413: StepAction LastStepAction() { return
thread_local_.last_step_action_; }
On 2014/11/18 11:46:39, Yang wrote:
> I'm curious why StepInActive is no longer sufficient. Did anything break?

A StepIn action may not necessarily lead to StepInActive() being true. e.g. a
StepIn may actually result in calling ActivateStepOut() instead.

In this patch we "promote" StepIn to also step into microtasks (and/or across
js->c++->js boundaries).
Otherwise, there is no way to step into Promise/O.o callbacks other than
setting
a breakpoint.

Similar effort to promise StepInto across Blink task boundaries:
https://codereview.chromium.org/732593002/

https://codereview.chromium.org/739523002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to