lgtm
https://codereview.chromium.org/728103008/diff/1/src/debug.h
File src/debug.h (right):
https://codereview.chromium.org/728103008/diff/1/src/debug.h#newcode598
src/debug.h:598: bool break_disabled_for_event_;
I'd rather call it something like in_debug_listener_ which would better
reflect current state.
https://codereview.chromium.org/728103008/diff/1/src/debug.h#newcode722
src/debug.h:722: bool previous_break_disabled_ : 1;
Does it really make sense to use bit fields here? To my taste they just
distract reader of the code.
https://codereview.chromium.org/728103008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
