Benchmarks looks promising. Please do review.

http://codereview.chromium.org/269004/diff/1/3
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/269004/diff/1/3#newcode7593
Line 7593: Label skip_allocation, non_smi_result,
operand_conversion_failure;
I'm considering using CheckFloatOperands first, to avoid converting one
operand and then going to the runtime if the other is a non-number. It
will double the smi checks, though.

http://codereview.chromium.org/269004/diff/1/4
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/269004/diff/1/4#newcode291
Line 291: subl(kScratchRegister, Immediate(1));
Just noticed that the previous two lines could be done with one lea
instruction.

http://codereview.chromium.org/269004

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to