LGTM, with minor issues: see Lwu comment, and you should add an OWNERS file
to
test/unittests/compiler/mips64.
We need some v8 team review as well, can one of you guys PTAL?
https://codereview.chromium.org/732403002/diff/40001/src/compiler/mips64/instruction-selector-mips64.cc
File src/compiler/mips64/instruction-selector-mips64.cc (right):
https://codereview.chromium.org/732403002/diff/40001/src/compiler/mips64/instruction-selector-mips64.cc#newcode185
src/compiler/mips64/instruction-selector-mips64.cc:185: opcode =
kMips64Lw;
Should we also have a kTypeUint32 check here, and use Lwu or Lw ?
https://codereview.chromium.org/732403002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
