Reviewers: Michael Achenbach,
Description:
Revert "Forward declaration for Isolate / Platform in libplatform.h."
and "Fixes
d8 on windows following.".
This reverts commit 0f57ce8f1a3d6b4f3a4b65739d719b8467ff5d9c.
and 3245b8cb832f4a948aff9fb1c271cc08c4690d3b for breaking Chromium
compile.
[email protected]
Please review this at https://codereview.chromium.org/743533003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -9 lines):
M include/libplatform/libplatform.h
M samples/lineprocessor.cc
M samples/shell.cc
M src/d8.cc
M test/unittests/run-all-unittests.cc
Index: include/libplatform/libplatform.h
diff --git a/include/libplatform/libplatform.h
b/include/libplatform/libplatform.h
index
c818fec1c8cb2d98b3ff147dde1123d65f98e083..2125e9746b93ca724a9d0cf6992ca2cfc00e5e33
100644
--- a/include/libplatform/libplatform.h
+++ b/include/libplatform/libplatform.h
@@ -5,11 +5,9 @@
#ifndef V8_LIBPLATFORM_LIBPLATFORM_H_
#define V8_LIBPLATFORM_LIBPLATFORM_H_
-namespace v8 {
-
-class Isolate;
-class Platform;
+#include "include/v8-platform.h"
+namespace v8 {
namespace platform {
/**
Index: samples/lineprocessor.cc
diff --git a/samples/lineprocessor.cc b/samples/lineprocessor.cc
index
ce502f073695e640515dc7331c204037acdc8507..69bfab49ba64dd8f0f9c84792bad9ffe4124ace9
100644
--- a/samples/lineprocessor.cc
+++ b/samples/lineprocessor.cc
@@ -29,7 +29,6 @@
#include <include/libplatform/libplatform.h>
#include <include/v8-debug.h>
-#include <include/v8-platform.h>
#include <fcntl.h>
#include <stdio.h>
Index: samples/shell.cc
diff --git a/samples/shell.cc b/samples/shell.cc
index
f84838f4f760b713e15f2e457b3977948c944a01..b66e8f7453d1b38c323b157d5859778f3441b98b
100644
--- a/samples/shell.cc
+++ b/samples/shell.cc
@@ -28,7 +28,6 @@
#include <include/v8.h>
#include <include/libplatform/libplatform.h>
-#include <include/v8-platform.h>
#include <assert.h>
#include <fcntl.h>
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index
c4550b65bb29e7cf97e9e1d94bb75a02f97d939a..fd80fcdc036795f4dab92cac0be96955683781c3
100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -40,8 +40,6 @@
#include "src/d8.h"
#include "include/libplatform/libplatform.h"
-#include "include/v8-platform.h"
-
#ifndef V8_SHARED
#include "src/api.h"
#include "src/base/cpu.h"
Index: test/unittests/run-all-unittests.cc
diff --git a/test/unittests/run-all-unittests.cc
b/test/unittests/run-all-unittests.cc
index
7c3a7abbd4a6634fa0307bf6e5fe879e14eec304..8c361ddc3683eeb4af4f432b1454f540de41fbf9
100644
--- a/test/unittests/run-all-unittests.cc
+++ b/test/unittests/run-all-unittests.cc
@@ -4,7 +4,6 @@
#include "include/libplatform/libplatform.h"
#include "include/v8.h"
-#include "include/v8-platform.h"
#include "src/base/compiler-specific.h"
#include "testing/gmock/include/gmock/gmock.h"
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
