lgtm with nits.
https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc#newcode994
src/compiler/register-allocator.cc:994: // TODO(dcarney): this in no
longer reachable.
How about DCHECK(!to_range->is_phi()), then?
https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc#newcode1317
src/compiler/register-allocator.cc:1317: /* resolve phis */
// style comment?
https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc#newcode1321
src/compiler/register-allocator.cc:1321: auto* block_bound =
Yeah, this would deserve some comment and/or cleanup.
https://codereview.chromium.org/738853002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
