Reviewers: jarin,
https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc#newcode994
src/compiler/register-allocator.cc:994: // TODO(dcarney): this in no
longer reachable.
On 2014/11/19 15:43:04, jarin wrote:
How about DCHECK(!to_range->is_phi()), then?
i just nuked all the is_phi stuff instead
https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc#newcode1317
src/compiler/register-allocator.cc:1317: /* resolve phis */
On 2014/11/19 15:43:04, jarin wrote:
// style comment?
Done.
https://codereview.chromium.org/738853002/diff/60001/src/compiler/register-allocator.cc#newcode1321
src/compiler/register-allocator.cc:1321: auto* block_bound =
On 2014/11/19 15:43:04, jarin wrote:
Yeah, this would deserve some comment and/or cleanup.
cleaned up
Description:
[turbofan]: delay ssa deconstruction in register allocator
BUG=
Please review this at https://codereview.chromium.org/738853002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+122, -162 lines):
M src/compiler/instruction.h
M src/compiler/instruction.cc
M src/compiler/instruction-selector.cc
M src/compiler/pipeline.cc
M src/compiler/register-allocator.h
M src/compiler/register-allocator.cc
M src/compiler/register-allocator-verifier.cc
M test/unittests/compiler/register-allocator-unittest.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
