LGTM with minor issues.
https://codereview.chromium.org/722203006/diff/40001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/722203006/diff/40001/test/cctest/test-parsing.cc#newcode1375
test/cctest/test-parsing.cc:1375: printf("SetParserFlags: %d\n",
flags.Contains(kAllowHarmonySloppy));
Remove?
https://codereview.chromium.org/722203006/diff/40001/test/mjsunit/harmony/block-non-strict-errors.js
File test/mjsunit/harmony/block-non-strict-errors.js (right):
https://codereview.chromium.org/722203006/diff/40001/test/mjsunit/harmony/block-non-strict-errors.js#newcode33
test/mjsunit/harmony/block-non-strict-errors.js:33: CheckError("1, class
{};");
I assume your intention was to test class expression here. But this is
parsing a statement so you need add parens around the expression.
https://codereview.chromium.org/722203006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
