Reviewers: Toon Verwaest,

Message:
PTAL

Description:
Removed unnecessary generalization of all fields in
Map::GeneralizeRepresentation() (introduced in r25082).

This generalization causes unnecessary map deprecation when the transition tree
of the split map is full.

BUG=chromium:431807
LOG=N

Please review this at https://codereview.chromium.org/736953003/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+0, -4 lines):
  M src/objects.cc


Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index cdd6718736f2ebdec3695fbd55ee65b284561133..134b308ff4b8d0a01ea1219d75104fff503a3821 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -2755,10 +2755,6 @@ Handle<Map> Map::GeneralizeRepresentation(Handle<Map> old_map,
   // Add missing transitions.
   Handle<Map> new_map = split_map;
   for (int i = split_nof; i < old_nof; ++i) {
-    if (!new_map->CanHaveMoreTransitions()) {
- return CopyGeneralizeAllRepresentations(old_map, modify_index, store_mode, - "can't have more transitions");
-    }
     new_map = CopyInstallDescriptors(new_map, i, new_descriptors,
                                      new_layout_descriptor);
   }


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to