On 2014/11/19 19:27:06, Jakob wrote:
LGTM.

I've changed the description to LOG=n. The rule for "y" is: "is this change interesting to external users/embedders who might read the ChangeLog?", where
making a test faster is a clear counter-example.

The biggest improvement I can think of would come from introducing a
"kAllowAllExperimentalFeatures" parser flag, to be used by tests, that would imply the flags for individual harmony features that the various parser tests currently pass in, and thereby get the number of flag combinations from 1 << 8 down to 1 << 3 or so (if kAllowLazy and kAllowNativesSyntax remain separate).

In this case, the different combinations of the flags is not important. Let me
split it up.

https://codereview.chromium.org/724713004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to