On 2014/11/19 21:16:47, Dmitry Lomov (chromium) wrote:
On 2014/11/19 20:35:03, adamk wrote:
> I'm very surprised to hear that this is being changed so late in the
game.
> According to:
>
> http://kangax.github.io/compat-table/es6/#WeakMap
>
> WeakMap.prototype.clear is present in the latest versions of IE,
Firefox,
> Safari, Opera, and Chrome. For Chrome, it's been exposed for around six
months.
>
> If we're going to remove this, I think it'd ideally be done with a flag
so
we
> can easily reverse course if it turns out this breaks content we care
about.
I am not sure what the flag will solve here - we can revert the CL if
worse
comes to worse.
OK, lgtm if you're fine with that. I was under the impression that we were
trying to get away from having to make code changes when we broke stuff on a
release branch, but I'll admit that this'll be a pretty straightforward
revert
if it comes to that.
https://codereview.chromium.org/739303002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.