https://codereview.chromium.org/742643003/diff/60001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/742643003/diff/60001/src/parser.cc#newcode5310
src/parser.cc:5310: hash_string[num_hash_chars++] = '.';
Can we skip the '.' here?
https://codereview.chromium.org/742643003/diff/60001/src/parser.cc#newcode5315
src/parser.cc:5315: source->ToCString(ALLOW_NULLS,
FAST_STRING_TRAVERSAL, span_start,
I still think this is suspicious. The scanner knows how to handle one vs
two byte strings. Lets stick with this known faulty implementation and
I'll add a blocking bug to get this fixed.
https://codereview.chromium.org/742643003/diff/60001/src/parser.cc#newcode5334
src/parser.cc:5334: // Convert to UTF16 --- One-byte AstRawStrings do
not seem to be
one byte is used for ascii
https://codereview.chromium.org/742643003/diff/60001/src/parser.cc#newcode5336
src/parser.cc:5336: unibrow::Utf8Decoder<256> decoder(raw_chars.get(),
to_index);
On 2014/11/19 20:16:54, caitp wrote:
A better solution for this is probably to make sure one-byte
AstRawStrings can
decode UTF8 properly.
This works for now, though.
We have code in the scanner for handling this already. At this point I
think we should ignore the one vs two byte string issue in this cl and
start a new CL just about that.
Lets focus on the caching of the template pattern object.
https://codereview.chromium.org/742643003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
