Awesome catch! LGTM, just nits.
A regression test would be amazing, can you try Erik's idea? I guess you
would
have to make some of the code objects survive.
https://codereview.chromium.org/742733002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/742733002/diff/20001/src/heap/heap.cc#newcode5265
src/heap/heap.cc:5265: isolate_->code_range()->ReserveEmergencyBlock();
Can we do that after setting up code_range?
https://codereview.chromium.org/742733002/diff/20001/src/heap/spaces.h
File src/heap/spaces.h (right):
https://codereview.chromium.org/742733002/diff/20001/src/heap/spaces.h#newcode939
src/heap/spaces.h:939: FreeBlock emergency_block_;
Please add a comment that describes the concept of the emergency block.
https://codereview.chromium.org/742733002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
