https://codereview.chromium.org/739913003/diff/1/src/third_party/fdlibm/fdlibm.cc
File src/third_party/fdlibm/fdlibm.cc (right):
https://codereview.chromium.org/739913003/diff/1/src/third_party/fdlibm/fdlibm.cc#newcode30
src/third_party/fdlibm/fdlibm.cc:30: 6.36619772367581382433e-01, //
invpio2 0
On 2014/11/19 19:02:30, Raymond Toy wrote:
Did you insert tabs here? Does the V8 coding style allow that? Even
if it is
allowed, that seems unnecessary for this CL.
Merely moved by one whitespace to fit the comments for the new entries.
https://codereview.chromium.org/739913003/diff/1/test/mjsunit/es6/math-log2-log10.js
File test/mjsunit/es6/math-log2-log10.js (right):
https://codereview.chromium.org/739913003/diff/1/test/mjsunit/es6/math-log2-log10.js#newcode43
test/mjsunit/es6/math-log2-log10.js:43: assertEqualsDelta(i,
Math.log10(Math.pow(10, i)), 1E-16);
On 2014/11/19 19:02:30, Raymond Toy wrote:
Nit: It would be useful to have a more accurate bound than 1e-16, in
case log10
or pow changes slightly.
Done.
https://codereview.chromium.org/739913003/diff/1/test/mjsunit/es6/math-log2-log10.js#newcode51
test/mjsunit/es6/math-log2-log10.js:51:
assertEquals(-307.77759430519706, Math.log10(1.5 * Math.pow(2, -1023)));
On 2014/11/19 19:02:30, Raymond Toy wrote:
Add comment that you're testing a denormal case.
Done.
https://codereview.chromium.org/739913003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
