Looks good with a couple comments.
https://codereview.chromium.org/738073002/diff/60001/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/738073002/diff/60001/src/compiler/instruction-selector.cc#newcode157
src/compiler/instruction-selector.cc:157: bool
InstructionSelector::ValueOwnedBy(Node* owner, Node* value) const {
Maybe we can move this to a more generic location like NodeProperties?
Also, a test.
https://codereview.chromium.org/738073002/diff/60001/src/compiler/instruction-selector.cc#newcode160
src/compiler/instruction-selector.cc:160: for (Node::Uses::iterator
current = uses.begin(); current != uses.end();
You can use a C++ foreach here now!
https://codereview.chromium.org/738073002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
