Coming a bit late to the party, but anyway... :-)
https://codereview.chromium.org/736043002/diff/40001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/736043002/diff/40001/src/ast.h#newcode1930
src/ast.h:1930: class IsUninitializedField : public BitField8<bool, 0,
1> {};
This is not so good for 2 reasons: Even on 32bit, we have 2 bytes
internal padding "for free" at the beginning of this class, so small new
stuff should go there. Furthermore, using BitField complicates things, a
plain old bool would be more efficient and we have the room anyway.
https://codereview.chromium.org/736043002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
