lgtm modulo bunch of comments.
https://codereview.chromium.org/748773002/diff/1/src/compiler/graph-visualizer.cc
File src/compiler/graph-visualizer.cc (right):
https://codereview.chromium.org/748773002/diff/1/src/compiler/graph-visualizer.cc#newcode726
src/compiler/graph-visualizer.cc:726: int index = -1;
How about DCHECK((range->TopLevel()->GetSpillRange() != nullptr) ==
FLAG_turbo_reuse_spill_slots)?
https://codereview.chromium.org/748773002/diff/1/src/compiler/register-allocator.cc
File src/compiler/register-allocator.cc (right):
https://codereview.chromium.org/748773002/diff/1/src/compiler/register-allocator.cc#newcode549
src/compiler/register-allocator.cc:549:
use_spill_ranges_(FLAG_turbo_reuse_spill_slots) {
Why is there this extra indirection? Can't we use the naked flag? (That
will simplify the removal once we are done.)
https://codereview.chromium.org/748773002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/748773002/diff/1/src/flag-definitions.h#newcode391
src/flag-definitions.h:391: DEFINE_BOOL(turbo_reuse_spill_slots, false,
"reuse spill slots in TurboFan")
Please, add a TODO explaining that this is just temporary for
experimentation.
https://codereview.chromium.org/748773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
