On 2014/11/21 11:54:05, Yang wrote:
On 2014/11/21 11:51:10, vogelheim1 wrote:
> On 2014/11/21 11:50:50, vogelheim1 wrote:
> > lgtm - provided caveats below are solved.
> >
> > I think this may be missing two cases:
> > - BUILD.gn
> > - cctest/cctest.gyp
>
> Oh wait, cctest.gyp was in. But BUILD.gn is missing. :)
ah yes. Forgot the gn build as usual :/
One more thing: This is an API change, so a note should end up in our API
change
doc.
https://codereview.chromium.org/750543002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
