http://codereview.chromium.org/246075/diff/4001/4002 File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/246075/diff/4001/4002#newcode830 Line 830: __ CallStub(&stub); On 2009/10/08 13:16:54, Kevin Millikin wrote: > The call to masm_->CallStub could better go into the stub's > GeneratePrepareArguments function (and that function should be renamed to > something like 'Call'). > I wonder if there's a simple way to assert that the preparation is done before > someone tries to CallStub? Changed the name to GenerateCall and included the macro assembler call to CallStub. http://codereview.chromium.org/246075/diff/4001/4003 File src/ia32/codegen-ia32.h (right): http://codereview.chromium.org/246075/diff/4001/4003#newcode624 Line 624: // The flags ARGS_IN_REGISTERS and ARGS_REVERSED are used internally. On 2009/10/08 13:16:54, Kevin Millikin wrote: > Since they are not flags passed to the constructor, they do not need to go in > the enum type, and be encoded as separate bits in the key. You can then avoid > the following assert. Removed flags from the enum and added them as private bool fields instead. http://codereview.chromium.org/246075 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
