LGTM if the compile error reported by bot is fixed:
../src/heap/gc-tracer.cc: In member function ‘double
v8::internal::GCTracer::ContextDisposalRateInMilliseconds() const’:
../src/heap/gc-tracer.cc:493:41: error: comparison between signed and
unsigned
integer expressions [-Werror=sign-compare]
cc1plus: all warnings being treated as errors
make: *** [Release/obj.target/v8_base/src/heap/gc-tracer.o] Error 1
https://codereview.chromium.org/750963002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.