https://codereview.chromium.org/749213004/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/749213004/diff/1/BUILD.gn#newcode1418
BUILD.gn:1418: deps = []
On 2014/11/24 17:21:06, rmcilroy wrote:
Is there any reason you need to make these changes? I would have
thought the
if/else if/else structure before would have given you the same result?
I thought the same :). But no :)
When you have the structure:
if (v8_use_external_startup_data)
do something;
else if (v8_snapshot)
do something else;
else
do another thing;
if v8_use_external_startup_data is true, it won't consider the other
branches exist. And then it'll complain that v8_snapshot was defined but
never used :)
https://codereview.chromium.org/749213004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
