On 2014/11/24 15:59:09, dcarney wrote:
lgtm
https://codereview.chromium.org/754843002/diff/1/src/compiler/jump-threading.cc
File src/compiler/jump-threading.cc (right):
https://codereview.chromium.org/754843002/diff/1/src/compiler/jump-threading.cc#newcode87
src/compiler/jump-threading.cc:87: } else if (instr->arch_opcode() ==
kArchNop)
{
a bunch of stuff is encoded as nops - you want to continue if outputcount
== 0
&& inputcount == 0 && tempcount == 0 (or create and use instructions for
the
other cases)
We should not abuse nops, but I added your suggests.
https://codereview.chromium.org/754843002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/754843002/diff/1/src/compiler/pipeline.cc#newcode918
src/compiler/pipeline.cc:918: // Optimimize jumps.
if (FLAG_turbo_jt)
Done.
https://codereview.chromium.org/754843002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
