Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Don't double smi-tag the mask used to check read-only / field mode in the
dictionary-store-stub on X64
BUG=
Please review this at https://codereview.chromium.org/757673002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -3 lines):
M src/ic/x64/ic-x64.cc
Index: src/ic/x64/ic-x64.cc
diff --git a/src/ic/x64/ic-x64.cc b/src/ic/x64/ic-x64.cc
index
f125322645ceaf6a565f80187a6a86d51ea926c7..c7345603b7459c06602b4d23e47635629effb6ce
100644
--- a/src/ic/x64/ic-x64.cc
+++ b/src/ic/x64/ic-x64.cc
@@ -119,9 +119,8 @@ static void GenerateDictionaryStore(MacroAssembler*
masm, Label* miss_label,
NameDictionary::kElementsStartIndex * kPointerSize;
const int kDetailsOffset = kElementsStartOffset + 2 * kPointerSize;
const int kTypeAndReadOnlyMask =
- (PropertyDetails::TypeField::kMask |
- PropertyDetails::AttributesField::encode(READ_ONLY))
- << kSmiTagSize;
+ PropertyDetails::TypeField::kMask |
+ PropertyDetails::AttributesField::encode(READ_ONLY);
__ Test(Operand(elements, scratch1, times_pointer_size,
kDetailsOffset - kHeapObjectTag),
Smi::FromInt(kTypeAndReadOnlyMask));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
