Comment #8 on issue 3696 by [email protected]: Add fast path for smis
to Number.isInteger()
https://code.google.com/p/v8/issues/detail?id=3696
Just a few quick remarks regarding #7: From a 10000ft perspective, this
looks easy, but as always, the devil is in the details. In our case, I can
see at least 3 "devils":
* When exactly should the folding of those 2 diamonds into 1 be done?
Note that D is duplicated, so in general this is a *bad* transformation
(unless you can prove that it simplifies things later).
* Which diamonds should be used for the above transformation? There can
be various non-equivalent coverings, some might be helpful, some might not.
* Without using e.g. SSI (which Crankshaft doesn't do), it's very hard
to let different pieces of information flow into the branches ("This is
definitely a Smi", "This is definitely not a Smi").
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
