Reviewers: Benedikt Meurer,
Description:
Disable ParserSync test for now, it takes waaaaay too long.
Running this in x64.release mode on a powerful HP620 takes 4 seconds,
this is at least 2 orders of magnitude too slow and leads to tons of
false positives on our build bots due to timeouts. As it is, the
cost-benefit ratio is far too low.
The whole approach needs to be changed: Instead of trying to exhaust
some search space in unit tests, this should be turned into a fuzzing
test where only a small but random number of things are tested. The
exhaustive approach can be done separately, but definitely not in the
unit tests.
BUG=v8:3707
Please review this at https://codereview.chromium.org/762743002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -1 lines):
M test/cctest/test-parsing.cc
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index
99965d2aebd5ddcaca3e2be1fdcc6f6b4f97702a..80d34066013d43f0c952d9a4353d406f3f797e47
100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -1509,7 +1509,9 @@ void TestParserSync(const char* source,
}
-TEST(ParserSync) {
+// TODO(marja) This needs to be turned into a fuzzing test, trying all
those
+// combinations below takes at least 2 orders of magnitude too long.
+DISABLED_TEST(ParserSync) {
const char* context_data[][2] = {
{ "", "" },
{ "{", "}" },
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
