LGTM with a nit
https://codereview.chromium.org/762493006/diff/20001/src/compiler/node-matchers.h
File src/compiler/node-matchers.h (right):
https://codereview.chromium.org/762493006/diff/20001/src/compiler/node-matchers.h#newcode108
src/compiler/node-matchers.h:108: return this->Is(0.0) &&
std::signbit(this->Value());
std::signbit is a C++11 library feature, plain signbit is not.
https://codereview.chromium.org/762493006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.