On 2014/11/26 10:46:15, Yang wrote:
https://codereview.chromium.org/762773002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/762773002/diff/1/src/objects.cc#newcode9291
src/objects.cc:9291: String::WriteToFlat(cons_string, one_byte_buffer, 0,
length);
Wouldn't this cause OOB writes for large strings? I think what you want is
Min(length, String::kMaxHashCalcLength).
right... that got lost in a refactor somewhere
ptal now
https://codereview.chromium.org/762773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
