Reviewers: jarin,
Message:
Slowly deprecating ZoneList, just 245 other occurrences in the code base. :)
Description:
Switch backedge table in scheduler to use ZoneVector.
[email protected]
Please review this at https://codereview.chromium.org/761733002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -5 lines):
M src/compiler/scheduler.cc
Index: src/compiler/scheduler.cc
diff --git a/src/compiler/scheduler.cc b/src/compiler/scheduler.cc
index
8c169368e54d5e8883e6184d542d7b02e5a34c18..07d1ca287e82c967257e0c61a8d896195ba5b277
100644
--- a/src/compiler/scheduler.cc
+++ b/src/compiler/scheduler.cc
@@ -530,7 +530,7 @@ class SpecialRPONumberer : public ZoneObject {
order_(NULL),
loops_(zone),
beyond_end_(NULL),
- backedges_(1, zone),
+ backedges_(zone),
stack_(zone),
previous_block_count_(0) {}
@@ -700,7 +700,7 @@ class SpecialRPONumberer : public ZoneObject {
if (succ->rpo_number() == kBlockVisited1) continue;
if (succ->rpo_number() == kBlockOnStack) {
// The successor is on the stack, so this is a backedge (cycle).
- backedges_.Add(Backedge(frame->block, frame->index - 1), zone_);
+ backedges_.push_back(Backedge(frame->block, frame->index - 1));
if (!HasLoopNumber(succ)) {
// Assign a new loop number to the header if it doesn't have
one.
SetLoopNumber(succ, num_loops++);
@@ -870,7 +870,7 @@ class SpecialRPONumberer : public ZoneObject {
// Computes loop membership from the backedges of the control flow graph.
void ComputeLoopInfo(ZoneVector<SpecialRPOStackFrame>& queue,
- size_t num_loops, ZoneList<Backedge>* backedges) {
+ size_t num_loops, ZoneVector<Backedge>* backedges) {
// Extend existing loop membership vectors.
for (LoopInfo& loop : loops_) {
BitVector* new_members = new (zone_)
@@ -884,7 +884,7 @@ class SpecialRPONumberer : public ZoneObject {
// Compute loop membership starting from backedges.
// O(max(loop_depth) * max(|loop|)
- for (int i = 0; i < backedges->length(); i++) {
+ for (size_t i = 0; i < backedges->size(); i++) {
BasicBlock* member = backedges->at(i).first;
BasicBlock* header = member->SuccessorAt(backedges->at(i).second);
size_t loop_num = GetLoopNumber(header);
@@ -1030,7 +1030,7 @@ class SpecialRPONumberer : public ZoneObject {
BlockList* order_;
ZoneVector<LoopInfo> loops_;
BasicBlock* beyond_end_;
- ZoneList<Backedge> backedges_;
+ ZoneVector<Backedge> backedges_;
ZoneVector<SpecialRPOStackFrame> stack_;
size_t previous_block_count_;
};
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
