Lgtm with a couple of final comments.
Also - you could link this with crbug.com/417668, which I've just made you
owner
of :).
https://codereview.chromium.org/750813003/diff/310001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/750813003/diff/310001/src/heap/gc-idle-time-handler.cc#newcode192
src/heap/gc-idle-time-handler.cc:192: GCIdleTimeAction
GCIdleTimeHandler::Compute(double idle_time_in_ms,
Maybe just keep this as a size_t since you cast it to size_t whenever
you use it here.
https://codereview.chromium.org/750813003/diff/310001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/750813003/diff/310001/src/heap/heap.cc#newcode4460
src/heap/heap.cc:4460:
static_cast<double>(base::Time::kMillisecondsPerSecond));
nit - would be good to have a helper for
MonotonicallyIncreasingTimeInMs() (in Platform?) instead of doing this
each time.
https://codereview.chromium.org/750813003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
