https://codereview.chromium.org/23248006/diff/11001/include/v8config.h
File include/v8config.h (right):
https://codereview.chromium.org/23248006/diff/11001/include/v8config.h#newcode118
include/v8config.h:118: #if defined(__clang__)
This doesn't look like a good approach to me. Clang tries to look like
gcc, or like cl.exe, depending on how it's invoked. All of other
chrome's projects let their COMPILER_GCC include clang in gcc mode, and
their COMPILER_MSVC clang in ms mode, and then use a dedicated #if
__clang__ in the few places where this doesn't work out. Was this
approach considered?
The concrete reason why I'm looking at this: the V8_INT64_C macros are
incorrectly set when building with clang on Windows because clang isn't
allowed to go down the V8_CC_MSVC path in macros.h – and the non-msvc
path then thinks that "l" is the correct format string for pointers. But
while "long" is 64bit in 64bit builds on posix, it isn't on Windows. I
could fix that macro, but I think a better fix would be to get rid of
V8_CC_CLANG and let clang be included in the gcc and msvc code paths.
I'm happy to do this work if this sounds acceptable to you.
https://codereview.chromium.org/23248006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
