LGTM.

http://codereview.chromium.org/269049/diff/1/15
File src/parser.cc (right):

http://codereview.chromium.org/269049/diff/1/15#newcode2613
Line 2613: Statement* Parser::ParseForStatement(ZoneStringList* labels,
bool* ok) {
Perhaps there should be a comment saying that this returns a
ForStatement or a ForInStatement.

http://codereview.chromium.org/269049/diff/1/2
File src/prettyprinter.cc (right):

http://codereview.chromium.org/269049/diff/1/2#newcode181
Line 181: Visit(node->next());  // prints extra ';', unfortunately
I don't understand this comment.

http://codereview.chromium.org/269049

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to