Reviewers: rossberg, Yang,
Message:
PTAL
Description:
Ship harmony-strings
[email protected], [email protected]
LOG=Y
Please review this at https://codereview.chromium.org/761913002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -5 lines):
M BUILD.gn
M src/flag-definitions.h
M tools/gyp/v8.gyp
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index
4e7b91c606af68b2981f1656bb875d9368f8e93b..412382505d23604f9085f95e00b9c0be2281d330
100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -196,6 +196,7 @@ action("js2c") {
"src/debug-debugger.js",
"src/mirror-debugger.js",
"src/liveedit-debugger.js",
+ "src/harmony-string.js",
"src/macros.py",
]
@@ -234,7 +235,6 @@ action("js2c_experimental") {
"src/macros.py",
"src/proxy.js",
"src/generator.js",
- "src/harmony-string.js",
"src/harmony-array.js",
"src/harmony-typedarray.js",
"src/harmony-classes.js",
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
a91d0eb07fcfa88be9514a18de53a06d72a2b410..4b4f2dcee254d56b27650fffe0c47358a167e200
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -176,12 +176,12 @@ DEFINE_IMPLICATION(es_staging, harmony)
// Features that are complete (but still behind --harmony/es-staging flag).
#define HARMONY_STAGED(V) \
- V(harmony_strings, "harmony string methods") \
V(harmony_scoping, "harmony block scoping")
// Features that are shipping (turned on by default, but internal flag
remains).
-#define HARMONY_SHIPPING(V) \
- V(harmony_numeric_literals, "harmony numeric literals")
+#define HARMONY_SHIPPING(V) \
+ V(harmony_numeric_literals, "harmony numeric literals") \
+ V(harmony_strings, "harmony string methods")
// Once a shipping feature has proved stable in the wild, it will be
dropped
// from HARMONY_SHIPPING, all occurrences of the FLAG_ variable are
removed,
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index
d634cc208af8dc2e9c1d1cf434c08bd2f522154d..08cd4eb24a3a990e5cb07aec1c3544660e8ded73
100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -1623,13 +1623,13 @@
'../../src/debug-debugger.js',
'../../src/mirror-debugger.js',
'../../src/liveedit-debugger.js',
+ '../../src/harmony-string.js',
'../../src/macros.py',
],
'experimental_library_files': [
'../../src/macros.py',
'../../src/proxy.js',
'../../src/generator.js',
- '../../src/harmony-string.js',
'../../src/harmony-array.js',
'../../src/harmony-tostring.js',
'../../src/harmony-typedarray.js',
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
