Hi Jan Thanks for the patch! Would you mind uploading it to our code review server as described in http://dev.chromium.org/developers/contributing-code? You can add me as the reviewer.
-- Christian On Mon, Oct 12, 2009 at 2:37 PM, Jan de Mooij <[email protected]> wrote: > Oops, forgot the patch... > > ---------- Forwarded message ---------- > From: Jan de Mooij <[email protected]> > Date: Mon, Oct 12, 2009 at 2:33 PM > Subject: Implementing String.prototype.trim and friends > To: [email protected] > > > Hello, > > Webkit recently added [1] support for ES5 String.prototype.trim and (like > Mozilla) trimLeft and trimRight. > Attached is a patch which implements this change in V8, based on the patch > for Webkit. It passes all Webkit unit tests. > > Before submitting it for review, I have one question: the constants > TrimLeft/TrimRight are now duplicated in string.js and in > Runtime::Runtime_StringTrim. > Is there a better way to do this? > > Regards, > Jan de Mooij > > > 1. https://bugs.webkit.org/show_bug.cgi?id=26590 > > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
