Thanks so much, --Michael
https://codereview.chromium.org/754303003/diff/80001/src/ast-numbering.cc
File src/ast-numbering.cc (right):
https://codereview.chromium.org/754303003/diff/80001/src/ast-numbering.cc#newcode79
src/ast-numbering.cc:79: if (FLAG_vector_ics) {
On 2014/11/27 14:15:58, Jakob wrote:
Do we even need this flag check? Wouldn't !FLAG_vector_ics imply
reqs.ic_slots==0, so we wouldn't get here?
Good point but no, because in the live tree we do have CALL_IC which is
vector-based. Since the live tree only has that one kind of IC, the
TypeFeedbackVector omits storing the little index that describes Kind
when FLAG_vector_ics is false.
https://codereview.chromium.org/754303003/diff/80001/src/factory.h
File src/factory.h (right):
https://codereview.chromium.org/754303003/diff/80001/src/factory.h#newcode13
src/factory.h:13: // Interface for handle based allocation.
On 2014/11/27 14:15:58, Jakob wrote:
nit: move this comment down two lines, it describes "class Factory".
Done.
https://codereview.chromium.org/754303003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
