Reviewers: Sven Panne,
Message:
PTAL
Description:
Make resources config ready for android test runner.
This switches off the resources feature. It will be solely
used for configuring files to be copied to android devices
in a follow up CL.
[email protected]
Please review this at https://codereview.chromium.org/764013002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -6 lines):
M tools/run_perf.py
M tools/unittests/run_perf_test.py
Index: tools/run_perf.py
diff --git a/tools/run_perf.py b/tools/run_perf.py
index
3d388f6b4d899e767bdf22e7dde852c7afb98e04..655f68199ed7dd3f1d36446527bafa2ea91ef801
100755
--- a/tools/run_perf.py
+++ b/tools/run_perf.py
@@ -18,7 +18,7 @@ The suite json format is expected to be:
"test_flags": [<flag to the test file>, ...],
"run_count": <how often will this suite run (optional)>,
"run_count_XXX": <how often will this suite run for arch XXX (optional)>,
- "resources": [<js file to be loaded before main>, ...]
+ "resources": [<js file to be moved to android device>, ...]
"main": <main js perf runner file>,
"results_regexp": <optional regexp>,
"results_processor": <optional python results processor script>,
@@ -293,7 +293,6 @@ class Runnable(Graph):
return (
[os.path.join(shell_dir, self.binary)] +
self.flags +
- self.resources +
[self.main] +
suffix
)
Index: tools/unittests/run_perf_test.py
diff --git a/tools/unittests/run_perf_test.py
b/tools/unittests/run_perf_test.py
index
0f84a73aecc25a95c2dd35bc154fa8fc573f5819..a384fb6d35f3cf30a601c8275b0cd0b154be9206
100644
--- a/tools/unittests/run_perf_test.py
+++ b/tools/unittests/run_perf_test.py
@@ -254,10 +254,8 @@ class PerfTest(unittest.TestCase):
], self._LoadResults()["traces"])
self._VerifyErrors([])
self._VerifyMockMultiple(
- (path.join("out", "x64.release", "d7"), "--flag", "file1.js",
- "file2.js", "run.js"),
- (path.join("out", "x64.release", "d7"), "--flag", "file1.js",
- "file2.js", "run.js"),
+ (path.join("out", "x64.release", "d7"), "--flag", "run.js"),
+ (path.join("out", "x64.release", "d7"), "--flag", "run.js"),
(path.join("out", "x64.release", "d8"), "--flag", "run.js"),
(path.join("out", "x64.release", "d8"), "--flag", "run.js"),
(path.join("out", "x64.release", "d8"), "--flag", "run.js"),
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
