Reviewers: ,
Message:
As mentioned in the CL description, I believe the draft's behaviour results
in a
quite observable difference in behaviour from the current implementations in
browsers.
I haven't done any research to verify if that difference could break
applications or not, but it might be good to answer those questions here.
Also as noted, this does not modify the runtime concat routine which
appears to
be carefully optimized for previously spec'd behaviour.
There are still some issues with the subclassed-array behaviour that is
mandated. Maybe a good place to figure that out
Description:
Implement ES6 @@isConcatSpreadable / Array.prototype.concat
Implement ES6 semantics for Array.prototype.concat, in JS only (Runtime
Array
functions and API not
impacted by this change).
There appear to be some observable differences from existing
Array.prototype.concat, mainly:
"hole" properties are not included in the resulting array.
This may be an intentional change, or my misreading the text. Will clear
that up
shortly.
BUG=
Please review this at https://codereview.chromium.org/771483002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+157, -0 lines):
M src/harmony-array.js
M src/runtime.js
A test/mjsunit/harmony/array-concat.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
