Reviewers: Dmitry Lomov (chromium),
Description:
Fix clang++ warnings on -Wtautological-constant-out-of-range-compare
BUG=v8:3730
LOG=N
[email protected]
Please review this at https://codereview.chromium.org/750093003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -2 lines):
M src/elements.h
M src/objects.h
Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index
9d86bbd657b5fde617ec05381de9e51cc06e1202..880c22ed956387fc19ea890d52774719a6a054b0
100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -179,7 +179,6 @@ class ElementsAccessor {
// Returns a shared ElementsAccessor for the specified ElementsKind.
static ElementsAccessor* ForKind(ElementsKind elements_kind) {
- DCHECK(elements_kind < kElementsKindCount);
return elements_accessors_[elements_kind];
}
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
c284a49ea6dc5e56a96e077d41d48efdc6c9717c..5a6c515138ef39597ad5e6d66816334c4118b750
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -5739,7 +5739,6 @@ class Map: public HeapObject {
inline bool is_prototype_map();
inline void set_elements_kind(ElementsKind elements_kind) {
- DCHECK(elements_kind < kElementsKindCount);
DCHECK(kElementsKindCount <= (1 << Map::ElementsKindBits::kSize));
set_bit_field2(Map::ElementsKindBits::update(bit_field2(),
elements_kind));
DCHECK(this->elements_kind() == elements_kind);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
