Reviewers: Michael Achenbach,
Description:
Make sure we have non-zero idle time even after rounding to size_t
BUG=v8:3728
[email protected]
LOG=n
Please review this at https://codereview.chromium.org/764263002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/heap/gc-idle-time-handler.cc
Index: src/heap/gc-idle-time-handler.cc
diff --git a/src/heap/gc-idle-time-handler.cc
b/src/heap/gc-idle-time-handler.cc
index
9bc7078c7461c1782006f5089f33dbbeb6e1a9b2..f89e7ae6d8e73a51e2f36f6decc42196f574c0e1
100644
--- a/src/heap/gc-idle-time-handler.cc
+++ b/src/heap/gc-idle-time-handler.cc
@@ -191,7 +191,7 @@ bool
GCIdleTimeHandler::ShouldDoFinalIncrementalMarkCompact(
// that this currently may trigger a full garbage collection.
GCIdleTimeAction GCIdleTimeHandler::Compute(double idle_time_in_ms,
HeapState heap_state) {
- if (idle_time_in_ms <= 0.0) {
+ if (static_cast<size_t>(idle_time_in_ms) <= 0) {
if (heap_state.incremental_marking_stopped) {
if (ShouldDoContextDisposalMarkCompact(
heap_state.contexts_disposed,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.