https://codereview.chromium.org/768203002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/768203002/diff/1/src/parser.cc#newcode5314
src/parser.cc:5314: for (int from_index = 0; from_index < length &&
stream.HasMore();
are there cases where the character stream would not have enough
characters (eg stream.HasMore() returns false)? It seems like it should
always be available, but maybe not.
https://codereview.chromium.org/768203002/diff/1/src/parser.cc#newcode5326
src/parser.cc:5326: normalized_raw_chars[to_index++] = ch;
move `last_was_cr = false;` here I think? (then can remove the
`continue` also)
https://codereview.chromium.org/768203002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
