Reviewers: ulan, danno, akos.palfi.imgtec, balazs.kilvady,
gergely.kis.imgtec, dusmil.imgtec,
Message:
PTAL.
Description:
MIPS: Use weak cells in map checks in polymorphic ICs.
Port 45a36948e1bb0f02d395ecbcfe6306553898268b
Fix typo in the mips ports.
BUG=
Please review this at https://codereview.chromium.org/767623003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -2 lines):
M src/mips/macro-assembler-mips.cc
M src/mips64/macro-assembler-mips64.cc
Index: src/mips/macro-assembler-mips.cc
diff --git a/src/mips/macro-assembler-mips.cc
b/src/mips/macro-assembler-mips.cc
index
2a5ea1adc5314f4ff6ba421f02f8014e5134bb8e..b2f60c5d2a09749cdedcbb862495d6ac1c01c3db
100644
--- a/src/mips/macro-assembler-mips.cc
+++ b/src/mips/macro-assembler-mips.cc
@@ -4033,7 +4033,7 @@ void MacroAssembler::LoadWeakValue(Register value,
Handle<WeakCell> cell,
Label* miss) {
li(value, Operand(cell));
lw(value, FieldMemOperand(value, WeakCell::kValueOffset));
- JumpIfNotSmi(value, miss);
+ JumpIfSmi(value, miss);
}
Index: src/mips64/macro-assembler-mips64.cc
diff --git a/src/mips64/macro-assembler-mips64.cc
b/src/mips64/macro-assembler-mips64.cc
index
3600e57e86326ccab03b0183f1fbd46f69f67d8e..b621e868a736658a4644c435fbe0c8b1a8fb31fa
100644
--- a/src/mips64/macro-assembler-mips64.cc
+++ b/src/mips64/macro-assembler-mips64.cc
@@ -4000,7 +4000,7 @@ void MacroAssembler::LoadWeakValue(Register value,
Handle<WeakCell> cell,
Label* miss) {
li(value, Operand(cell));
ld(value, FieldMemOperand(value, WeakCell::kValueOffset));
- JumpIfNotSmi(value, miss);
+ JumpIfSmi(value, miss);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
