On 2014/12/02 01:18:58, domenic wrote:
For tests I would like guidance as to how we should proceed. The existing
test262-format tests are at
https://github.com/tc39/Array.prototype.includes/tree/master/test.
1) Port the tests to mjsunit and commit them.
2) Add the ability to pull test262-format tests from arbitrary repos (in a
sibling folder, e.g. test262-other) and have it pull from
tc39/Array.prototype.includes
3) Add the ability to run checked-in test262 tests (in a sibling folder,
e.g.
test262-not-upstreamed-yet) and check in the tests. Doing so will probably
mean
modifying the copyright header of the tests to make the presubmit happy.
4) Get the tests merged into tc39/test262 proper, and add some way of
running
a
subset of test262 tests during development. This will probably be blocked
on
other test262-related changes, e.g. the fact that we are using the old
deprecated Python runner and not the new Node.js-based runner.
I am happy to do any of these, and I have a spike of 3) at
https://github.com/domenic/v8-git-mirror/tree/test262-not-upstreamed-yet
but
ran
into the copyright header issue and thought I'd better ask before moving
further.
It looks like the test262-es6 runner isn't able to pass in flags for
unshipped
features (or maybe it can and it's just not happening?), so that seems like
a
blocker for running these from test262 directly.
Would it be terrible to add v8-specific tests for this feature and remove
them
once it's handled by test262 proper? mjsunit would simplify adding the
needed
flags.
https://codereview.chromium.org/771863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
