Reviewers: Sven Panne,
Description:
Get rid of the unused __my_bool__ macro.
[email protected]
Please review this at https://codereview.chromium.org/770163002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -16 lines):
M src/globals.h
Index: src/globals.h
diff --git a/src/globals.h b/src/globals.h
index
9a071971db347a946143d8d728c1c64600ed0b00..01169d88df45ace5d927b7739fb92fe30fb052bb
100644
--- a/src/globals.h
+++ b/src/globals.h
@@ -89,22 +89,6 @@ namespace internal {
#define V8_DOUBLE_FIELDS_UNBOXING 0
#endif
-// Support for alternative bool type. This is only enabled if the code is
-// compiled with USE_MYBOOL defined. This catches some nasty type bugs.
-// For instance, 'bool b = "false";' results in b == true! This is a hidden
-// source of bugs.
-// However, redefining the bool type does have some negative impact on some
-// platforms. It gives rise to compiler warnings (i.e. with
-// MSVC) in the API header files when mixing code that uses the standard
-// bool with code that uses the redefined version.
-// This does not actually belong in the platform code, but needs to be
-// defined here because the platform code uses bool, and platform.h is
-// include very early in the main include file.
-
-#ifdef USE_MYBOOL
-typedef unsigned int __my_bool__;
-#define bool __my_bool__ // use 'indirection' to avoid name clashes
-#endif
typedef uint8_t byte;
typedef byte* Address;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
