On 2014/12/01 17:51:57, Benedikt Meurer wrote:
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-specialization.cc
File src/compiler/js-context-specialization.cc (right):
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-specialization.cc#newcode39
src/compiler/js-context-specialization.cc:39: return Reducer::NoChange();
Remove Reducer:: prefix.
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-specialization.cc#newcode54
src/compiler/js-context-specialization.cc:54: return Reducer::NoChange();
Remove Reducer:: prefix.
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-specialization.cc#newcode61
src/compiler/js-context-specialization.cc:61: return
Reducer::Changed(node);
Remove Reducer:: prefix.
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-specialization.cc#newcode79
src/compiler/js-context-specialization.cc:79: return
Reducer::Replace(constant);
Remove Reducer:: prefix.
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-specialization.cc#newcode89
src/compiler/js-context-specialization.cc:89: return Reducer::NoChange();
Remove Reducer:: prefix.
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-specialization.cc#newcode96
src/compiler/js-context-specialization.cc:96: return Reducer::NoChange();
Remove Reducer:: prefix.
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-specialization.cc#newcode110
src/compiler/js-context-specialization.cc:110: return
Reducer::Changed(node);
Remove Reducer:: prefix.
Done.
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-specialization.h
File src/compiler/js-context-specialization.h (right):
https://codereview.chromium.org/771713002/diff/1/src/compiler/js-context-specialization.h#newcode24
src/compiler/js-context-specialization.h:24: virtual Reduction
Reduce(Node*
node) OVERRIDE;
According to the style guide there should be at most one of virtual,
FINAL,
OVERRIDE per function. So in this case, remove virtual and OVERRIDE and
add
FINAL instead.
Acknowledged, but all the other reducers are wrong too. I'll just keep it
consistent and then we can fix them all at once.
https://codereview.chromium.org/771713002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
